Create SIMPLE Demos #663
Create SIMPLE Demos #663
Conversation
|
@kelle QueryDemo.ipynb needs comments / notes on how to further improve the notebook! |
There was a problem hiding this comment.
Pull Request Overview
This PR creates demonstration notebooks for the SIMPLE database project, specifically adding a visualization demo notebook that shows users how to visualize spectra and data from the database.
- Adds a new Jupyter notebook focused on visualizing spectra with SIMPLE
- Provides a structured template for demonstration purposes with placeholder sections
- Includes necessary imports for spectral data visualization and database querying
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| " ('CFBDS J022644.65-062522.0', 36.686, -6.4228, None, '2000', None, 'Albe11', None, None),\n", | ||
| " ('2MASS J05574102-1333264', 89.420954, -13.557334, None, None, None, 'Cruz18', None, 'not M'),\n", | ||
| " ('2MASS J09393548-2448279', 144.897834, -24.80775, None, None, '0939-2448', 'Tinn05.2326', None, None),\n", | ||
| " ('2MASS J22590210+1156035', 344.758944, 11.933929, None, None, None, 'Zhan18.2054', None, 'Discovery reference from t |
There was a problem hiding this comment.
I would not have this cell. You've shown how to use the Astrodbkit query methods and how to use sql_query, but now you're going into low-level API for SQLAlchemy itself. While useful, it probably doesn't belong in a notebook demonstrating quick/useful queries of SIMPLE.
| " ('CFBDS J022644.65-062522.0', 36.686, -6.4228, None, '2000', None, 'Albe11', None, None),\n", | ||
| " ('2MASS J05574102-1333264', 89.420954, -13.557334, None, None, None, 'Cruz18', None, 'not M'),\n", | ||
| " ('2MASS J09393548-2448279', 144.897834, -24.80775, None, None, '0939-2448', 'Tinn05.2326', None, None),\n", | ||
| " ('2MASS J22590210+1156035', 344.758944, 11.933929, None, None, None, 'Zhan18.2054', None, 'Discovery reference from t |
There was a problem hiding this comment.
Same for this cell and the rest of the notebook. This is not a SQLAlchemy notebook, it is a SIMPLE notebook. It's also not a visualization notebook. I recommend removing the cells with the low-level sqlalchemy aspects and moving the visualization stuff to the other notebook (I haven't taken a look at that one yet).
There was a problem hiding this comment.
Overall, think about the purpose of this notebook, what you want to get across and focus on that. It helps to add a lot more text, both in markdown and python to guide the user.
Short description: Moved from secret simple, two notebooks for querying the database and another for visualizing spectra and data.