Ingest astronomical properties of ultracool benchmarks

[kaseyLee123]

Short description: Include what type of data being ingested and appropriate references.

Link to relevant issue: Closes #110

For data ingests:
[ ] includes script used for ingest
[ ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table

[kaseyLee123]

I have a lot more json files changed because it reordered the parameters of each JSON file for some reason... I think it might be the order of the parameters I ingested in this script because its different than the other modeled parameters script..? But it's not like any of the existing data changed or got removed because the pytest cases made sense accordingly with the counters. You also might want to take a look at the csv file for missing sourcenames because it is definitely more than before. Not sure how I would just ingest the source since the csv file doesn't provide ra and dec data anyway

[kelle]

Great start! Two things

• Make sure the ingest script is only finding one source match - if there are multiple, save to a CSV
• Add a comment indicating the source of the data. E.g., "Ingested from compilation by Zhang et al. (bibcode or doi)"

[kaseyLee123]

I just pushed a few JSON files with the new csvs and pytest and everything

[kelle]

What do you think about using the sigfig package to round the values? https://sigfig.readthedocs.io/en/latest/api.html#uncertainty-u

[kaseyLee123]

https://sigfig.readthedocs.io/en/latest/api.html#uncertainty-u

I'm fine with that, how much should I cut off by?

[kaseyLee123]

Just pushed a few json files. I assumed for sigfig the cut off to be 2 decimal places based off other sources in the db. Also please look at my github comment for the eri-b (cold start). There is already an eri-b source with different data values in the same csv file so not sure if I should still change it to eri-b

[kelle]

SDSS J105213.51+442255.7

[kelle]

2MASS J17281150+3948593 is in the database, but no companions. Maybe open a new issue or add the companion and companion relationship.

[kelle]

epsilon IndiB

[kelle]

open a new issue or add new companion

[kelle]

looks great!

• go ahead and push the JSON files since there's only ~60 of them.
• investigate each source in the "no source" table and see what's up. Either figure out how to ingest or open issues. Search for the sources in the Names table of the sqlite file.