Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interface): import bootstrap and font awesome properly #81

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

endes0
Copy link
Member

@endes0 endes0 commented Dec 18, 2023

No description provided.

@endes0 endes0 requested a review from oxcabe February 14, 2024 16:04
@oxcabe oxcabe changed the title fix(interface): Import bootstrap and font awesome properly fix(interface): import bootstrap and font awesome properly Feb 15, 2024
Copy link
Member

@oxcabe oxcabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A personal recommendation: configure your text-editor / IDE to add newlines at the end of files. Running Prettier also corrects to this formatting style. Maybe it's a good idea to have pre-commit hooks that run project wise linters and formatters.

Feel free to share your thoughts on this and correct the aforementioned. Once it's done, LGTM and it's approved 👍

src/interface/styles/vendor/main.scss Show resolved Hide resolved
src/interface/styles/base/variables.scss Show resolved Hide resolved
@endes0 endes0 requested a review from oxcabe February 15, 2024 11:51
Copy link
Member

@oxcabe oxcabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oxcabe oxcabe merged commit f4eb332 into SIMDE-ULL:main Feb 15, 2024
1 check passed
endes0 added a commit to endes0/SIMDE that referenced this pull request Feb 16, 2024
)

* fix(interface): Import bootstrap and font awesome properly

* fixes
oxcabe added a commit that referenced this pull request Feb 23, 2024
* fix(interface): Import bootstrap and font awesome properly

* Remove dependency to queque for ROB

* Remove dependency to Queue for the prefetch unit

* Remove dependency to Queue for the Decoder

* Remove Queue

* Removed basic blocks and labes unused clases

* Separate ROB unit to a class and change the way is displayed

* [WIP] Separate Reserve Stations logic to a class

* [WIP] Separate Reserve Stations logic to a class

* finished  separate Reserve Stations logic to a class

* better visualization

* moved decoder and prefetcher logic to a class

* moved jump predictor to a class and change visualization

* Refactor functional unit

* Refactor code structure and paths

* Remove unused code and refactor code structure

* fixed machines config

* use instruction UUID instead of per unit reference

* fix cell color

* highlight current PC on VLIW machine

* minor fixes

* fix(interface): import bootstrap and font awesome properly (#81)

* fix(interface): Import bootstrap and font awesome properly

* fixes

* Removed useless constructors

* Finally, style

* fixes

* Removed clean on units and implemented a better instruction copy

* Integrated Memory.ts

Co-authored-by: oxcabe <[email protected]>

* fix

---------

Co-authored-by: oxcabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants