-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: more tests, functional tests, replace ava to vitest & fixes #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! You should merge the main branch into this one for the CI workflow to pass. I changed it to use yarn, as it was still using npm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the changes I am requesting here, we can skip the test
to describe/it
ones so we can keep advancing with the general refactor.
If we choose to skip those changes, it should still be referenced into a new issue and addressed in the future, where we can either reimplement the tests à la Rust or commit with the describe
approach.
I did not implement the tests in the correct way (with |
The main goal of this PR is to add new tests(mostly functional) and fix/refactor the current tests. It also fixes a lot of bugs and discovers new ones (#76 #75).
Closes #35