Interactive mode batch + src/tgt clearing #4759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwichmann
force-pushed
the
fix/interactive-targets
branch
from
5504a63 to
45926fe
Compare
On Windows, where batch mode exists, the changed_{sources,targets} lists
become important. In interactive mode, these were not cleared properly,
leading to incorrect results. Moved them into the memo dict, which is
dropped when necessary, to match the other source and target entries.
The testcase is taken from the issue, but needed to apply some of the
tricks for interactive-mode e2e tests, where testing is not entirely
straightforward.
Fixes SCons#3029
Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
fix/interactive-targets
branch
from
45926fe to
be119e4
Compare
mwichmann
changed the title
bdbaddog
reviewed
Sep 5, 2025
bdbaddog
reviewed
Sep 5, 2025
Signed-off-by: Mats Wichmann <[email protected]>
…ate all file headers to current copyright form (#13) * add explanation of tricky logic to stabilize interactive testing. Update all file headers to current copyright form * narrow down no trim whitespace to just interactive tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, where batch mode exists, the
changed_{sources,targets}lists become important. In interactive mode, these were not cleared properly, leading to incorrect results. Moved them into the memo dict, which is already dropped when necessary, to match the other source and target entries.Testcase constructed from the issue. Required some funny gyrations - testing interactive mode is tricky because of timing, we "send" some simulated typing, and that returns right away, not when SCons has completed the command.
Fixes #3029
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).