Skip to content

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Aug 21, 2025

  • Introduce a new internal property, hasSideNavigation, in the NavigationLayout class to track if a side navigation is present.

  • Update the logic so that hasSideNavigation is set based on the presence of side content.

  • Update SideNavigation documentation.

Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider:

feat(ui5-navigation-layout): adjust shellbar padding when side navigation is present

In addition, if you consider of additional value:

  • Introduce a new internal property, hasSideNavigation, in the NavigationLayout class to track if a side navigation is present.

Update the logic so that hasSideNavigation is set based on the presence of side content.

@TeodorTaushanov TeodorTaushanov changed the title feat(ui5-navigation-layout): update shellbar paddings according to the specification feat(ui5-navigation-layout): adjust shellbar padding when side navigation is present Aug 22, 2025
@TeodorTaushanov
Copy link
Member Author

Please consider:

feat(ui5-navigation-layout): adjust shellbar padding when side navigation is present

In addition, if you consider of additional value:

  • Introduce a new internal property, hasSideNavigation, in the NavigationLayout class to track if a side navigation is present.

Update the logic so that hasSideNavigation is set based on the presence of side content.

Done.

@TeodorTaushanov TeodorTaushanov requested a review from Stoev August 22, 2025 07:54
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@TeodorTaushanov TeodorTaushanov requested a review from Stoev August 25, 2025 07:41
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the docs in side navigation with something in that direction:

if you don't use navigation layout, you will need to handle yourself the following behaviour to follow the design

  • handle correct behaviour on phone and tablet
  • handle padding of shell bar

@TeodorTaushanov TeodorTaushanov merged commit 723493f into main Aug 26, 2025
12 checks passed
@TeodorTaushanov TeodorTaushanov deleted the nav_layout_paddings branch August 26, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants