-
Notifications
You must be signed in to change notification settings - Fork 280
feat(ui5-navigation-layout): adjust shellbar padding when side navigation is present #12175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider:
feat(ui5-navigation-layout): adjust shellbar padding when side navigation is present
In addition, if you consider of additional value:
- Introduce a new internal property,
hasSideNavigation
, in theNavigationLayout
class to track if a side navigation is present.
Update the logic so that hasSideNavigation is set based on the presence of side content.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the docs in side navigation with something in that direction:
if you don't use navigation layout, you will need to handle yourself the following behaviour to follow the design
- handle correct behaviour on phone and tablet
- handle padding of shell bar
Introduce a new internal property, hasSideNavigation, in the NavigationLayout class to track if a side navigation is present.
Update the logic so that hasSideNavigation is set based on the presence of side content.
Update SideNavigation documentation.