Skip to content

chore(ui5-side-navigation): make click event cancelable #11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 15, 2025
Merged

chore(ui5-side-navigation): make click event cancelable #11271

merged 13 commits into from
May 15, 2025

Conversation

s-todorova
Copy link
Contributor

@s-todorova s-todorova commented Apr 6, 2025 •
edited
Loading

  • Click event for <ui5-side-navigation-item> is cancelable
  • Enriched with event parameters about key modifiers:
    • altKey
    • ctrlKey
    • metaKey
    • shiftKey

JIRA: BGSOFUIRODOPI-3433
Fixes: #10603

@s-todorova s-todorova requested a review from a team April 28, 2025 13:40
dimovpetar
dimovpetar previously requested changes Apr 29, 2025
View reviewed changes
@s-todorova s-todorova requested a review from a team May 8, 2025 10:33
TeodorTaushanov
TeodorTaushanov previously requested changes May 12, 2025
View reviewed changes
Copy link
Member

@TeodorTaushanov TeodorTaushanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a navigation menu item is clicked, the click event is fired twice.

@s-todorova s-todorova dismissed stale reviews from TeodorTaushanov and dimovpetar May 13, 2025 07:55

Those changes are already done

TeodorTaushanov
TeodorTaushanov previously requested changes May 14, 2025
View reviewed changes
@s-todorova s-todorova merged commit 7a4f054 into main May 15, 2025
12 checks passed
@s-todorova s-todorova deleted the sn_click_preventable branch May 15, 2025 09:51
@TeodorTaushanov TeodorTaushanov mentioned this pull request May 22, 2025
Closed
1 task
@s-todorova s-todorova mentioned this pull request May 27, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

@dimovpetar dimovpetar dimovpetar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SideNavigation]: CustomEvent does not provide proper click details
3 participants
@s-todorova @TeodorTaushanov @dimovpetar