Skip to content

[INTERNAL] TaskRunner: Remove unused parameter #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[INTERNAL] TaskRunner: Remove unused parameter #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/build/TaskRunner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,13 +438,12 @@ class TaskRunner {
* @private
* @param {string} taskName Name of the task
* @param {Function} taskFunction Function which executed the task
* @param {object} taskParams Base parameters for all tasks
* @returns {Promise} Resolves when task has finished
*/
async _executeTask(taskName, taskFunction, taskParams) {
async _executeTask(taskName, taskFunction) {
this._log.startTask(taskName);
this._taskStart = performance.now();
await taskFunction(taskParams, this._log);
await taskFunction(this._log);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log argument is also unused, so we shouldn't pass it here, right?

if (this._log.isLevelEnabled("perf")) {
this._log.perf(`Task ${taskName} finished in ${Math.round((performance.now() - this._taskStart))} ms`);
}
Expand Down