feat: Offer autofix for deprecated Core APIs #639
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxreichmann
force-pushed
the
autofix-deprecated-core-apis
branch
4 times, most recently
from
7c8c5bc to
bb20759
Compare
RandomByte
requested changes
May 12, 2025
d3xter666
force-pushed
the
autofix-deprecated-core-apis
branch
from
a8caf5a to
1f24741
Compare
d3xter666
force-pushed
the
autofix-deprecated-core-apis
branch
from
fc44eab to
5fa49bb
Compare
maxreichmann
commented
May 16, 2025
Comment on lines
36
to
38
| ["byFieldGroupId", { | ||
| exportNameToBeUsed: "sap.ui.core.Control.getControlsByFieldGroupId", | ||
| }], |
There was a problem hiding this comment.
Is there a specific reason why the whole namespace is used in exportNameToBeUsed here instead of extracting it into moduleName as usual?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-991
Fixes #619.