feat: Autofix results #598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: CPOUI5FOUNDATION-989
Will be done in a separate PR
matz3
reviewed
Mar 10, 2025
| @@ -51,15 +51,17 @@ export interface UI5LinterOptions { | |||
| rootDir?: string; | |||
| } | |||
|
|
|||
| export async function ui5lint(options?: UI5LinterOptions): Promise<LintResult[]> { | |||
| export async function ui5lint(options?: UI5LinterOptions): | |||
There was a problem hiding this comment.
note that this is an incompatible change
There was a problem hiding this comment.
Absolutely!
That’s why I put it as a separate draft request.
Let’s discuss offline what would be the options for that functionality
There was a problem hiding this comment.
I came with an alternative approach here: #600
Each of them has its own flaws, but I think the one in the link is more convenient as it does not introduce backward incompatibilities
matz3
force-pushed
the
add-autofix
branch
4 times, most recently
from
5c397d5 to
69bb793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display information about the fixed problems from the autofix