Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cart Loading feature #20109

Merged
merged 5 commits into from
Mar 25, 2025
Merged

Add Cart Loading feature #20109

merged 5 commits into from
Mar 25, 2025

Conversation

FollowTheFlo
Copy link
Contributor

@FollowTheFlo FollowTheFlo commented Mar 21, 2025 •
edited
Loading

Added:

  • Load cart from cartId given by occ api
  • PunchoutCartInterceptor interceptor to add punchoutsId key/value in header for request with url : carts/{cartId}, if not there server returns error.
  • Added routing logic: when EDIT punchoutOperation and no ItemId -> route user to Cart Page.

@FollowTheFlo FollowTheFlo requested a review from a team as a code owner March 21, 2025 21:01
rmch91
rmch91 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@rmch91 rmch91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FollowTheFlo FollowTheFlo merged commit 1fd862f into epic/punchout Mar 25, 2025
10 checks passed
@FollowTheFlo FollowTheFlo deleted the feature/CXSPA-8596 branch March 25, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmch91 rmch91 rmch91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FollowTheFlo @rmch91