Bump fundamental styles to 0.39.0-rc.64 #4126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilewskaa
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal,
smahati and
walmazacn
as code owners
amilewskaa
force-pushed
the
4119-bump-fundamental-styles
branch
from
ef935d0 to
add100e
Compare
amilewskaa
changed the title
walmazacn
reviewed
Feb 20, 2025
| @@ -94,7 +94,7 @@ | |||
| <div | |||
| class="luigi-search fd-shellbar__group" | |||
| on:click|stopPropagation={() => {}} | |||
| aria-hidden={!isSearchFieldVisible} | |||
| inert={!isSearchFieldVisible} | |||
There was a problem hiding this comment.
Are you sure this change is needed? Now when 'globalSearchCentered' is enabled the search field is visible on desktop, but it's not functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#4119