fix(agentgateway): remove telemetry source attribution from _lob.py#227
Closed
tiagoek wants to merge 2 commits into
Closed
fix(agentgateway): remove telemetry source attribution from _lob.py#227tiagoek wants to merge 2 commits into
tiagoek wants to merge 2 commits into
Conversation
Remove _telemetry_source=Module.AGENTGATEWAY from create_destination_client calls in _fetch_auth_token and get_ias_client_id_lob, and drop the now-unused Module import.
Contributor
Author
SDK Module Review
Findings (1)
1 finding(s): 0 posted as inline comment(s) on the affected lines, 1 not tied to a code line (listed above). Generated by sdk-review-skill · v1 |
Contributor
Author
|
Closing in favor of a PR targeting Sebastian's fork directly so he can test on top of his work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requested by @smahr (PR #220) to remove telemetry source attribution from
_lob.pyspecifically, so that internal destination calls made by the LoB auth helpers are not counted as cross-module traffic fromAGENTGATEWAYin observability dashboards.What changes:
_telemetry_source=Module.AGENTGATEWAYfromcreate_destination_client()in_fetch_auth_tokenandget_ias_client_id_lobfrom sap_cloud_sdk.core.telemetry import Moduleimport0.35.1Why:
Without
_telemetry_source,record_metricstreats these calls as user-facing (source=None) rather than internal SDK plumbing. The intent is that the auth/IAS resolution steps in the LoB flow should not show up asAGENTGATEWAY → DESTINATIONcross-module metrics — they are transparent infrastructure calls on behalf of the consumer.Scope intentionally limited to
_lob.py:_fragments.pyretains_telemetry_source=Module.AGENTGATEWAYoncreate_fragment_client()— fragment discovery is a distinct step and that attribution is considered correct. Aligning_fragments.pyis out of scope for this PR.Test plan
_fetch_auth_tokenstill resolves auth tokens correctlyget_ias_client_id_lobstill returns the client ID correctlysource=AGENTGATEWAY