chore: Update model list #871
Conversation
packages/core/src/model-types.ts
Outdated
| | 'gemini-1.5-pro' | ||
| | 'gemini-1.5-flash' |
There was a problem hiding this comment.
The retirement date of these models are set to 24th September. Why are we removing them sooner? It is not set to deprecated too.
But, I see that they are also in recently retired models list. @ZhongpinWang Have you seen something like this before?
There was a problem hiding this comment.
The retired models have version 001. Version 002 of both models are not retired or deprecated. @emincihangeri Both of them should not be removed.
packages/core/src/model-types.ts
Outdated
| | 'amazon--titan-text-express' | ||
| | 'amazon--titan-text-lite' |
There was a problem hiding this comment.
[req] Both are deprecated. Please remove.
| /** | ||
| * AI Core open source models for chat completion. | ||
| */ | ||
| export type AiCoreOpenSourceChatModel = LiteralUnion< | ||
| | 'mistralai--mixtral-8x7b-instruct-v01' | ||
| | 'mistralai--mistral-large-instruct' | ||
| | 'mistralai--mistral-small-instruct' | ||
| | 'meta--llama3.1-70b-instruct' |
There was a problem hiding this comment.
[req] This model is deprecated. Please remove.
packages/core/src/model-types.ts
Outdated
| @@ -42,33 +41,24 @@ export type AwsBedrockChatModel = LiteralUnion< | |||
| | 'anthropic--claude-3-sonnet' | |||
| | 'anthropic--claude-3.5-sonnet' | |||
| | 'anthropic--claude-3.7-sonnet' | |||
| | 'anthropic--claude-4-opus' | |||
| | 'anthropic--claude-4-sonnet' | |||
| | 'amazon--titan-text-express' | |||
| | 'amazon--titan-text-lite' | |||
There was a problem hiding this comment.
[req] amazon--titan-text-express and amazon--titan-text-lite are also marked as deprecated. Consider removing them as well.
| /** | ||
| * AI Core open source models for chat completion. | ||
| */ | ||
| export type AiCoreOpenSourceChatModel = LiteralUnion< | ||
| | 'mistralai--mixtral-8x7b-instruct-v01' | ||
| | 'mistralai--mistral-large-instruct' | ||
| | 'mistralai--mistral-small-instruct' | ||
| | 'meta--llama3.1-70b-instruct' |
There was a problem hiding this comment.
[pp] meta--llama3.1-70b-instruct is also marked as deprecated but will only be retired by 30th September, so we can wait a bit longer here.
There was a problem hiding this comment.
No, we remove models in our SDK as soon as they are deprecated and announce the changes. This gives user some time to switch to newer model before the retirement. Otherwise, user may not check SAP notes and trust our SDK as we never announced anything. Then immediately at the retirement, their production code fails.
There was a problem hiding this comment.
I couldn't see a replacement for the deprecated model though. Is it okay to remove it or put it on the deprecated models list(in the documentation) without a replacement?
|
I am applying all the corrections and leave |
Also remember to change your base branch to |
|
Remember to make any necessary updates here, if applicable: https://sap.github.io/ai-sdk/docs/js/overview-cloud-sdk-for-ai-js#deprecated-models |
Context
Closes SAP/ai-sdk-js-backlog#360.
What this PR does and why it is needed
The deprecated and retired models are removed from the available model list. New models are added such as
amazon--nova-premier. The full correspondence with SAP notes is considered and applied.