chore: Remove deprecated models #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ export type AzureOpenAiChatModel = LiteralUnion< | |||
| * Azure OpenAI models for embedding. | |||
| */ | |||
| export type AzureOpenAiEmbeddingModel = LiteralUnion< | |||
| 'text-embedding-ada-002' | 'text-embedding-3-small' | 'text-embedding-3-large' | |||
| 'text-embedding-3-small' | 'text-embedding-3-large' | |||
There was a problem hiding this comment.
[q] A general question. Should we start removing deprecated (not retired) models already from types? If so, should we already remove other deprecated models? I would prefer we remove them now to give user some buffer to replace them before it gets permanently removed from remote service. @jjtang1985 What is your opinion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes SAP/ai-sdk-js-backlog#257.
What this PR does and why it is needed
Replaces
text-embedding-ada-002in our sample-code and documentation with the suggested replacements according to SAP notes.