Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add convenience for masking #604

Merged
merged 10 commits into from
Mar 20, 2025
Merged

feat: Add convenience for masking #604

merged 10 commits into from
Mar 20, 2025

Conversation

ZhongpinWang
Copy link
Contributor

@ZhongpinWang ZhongpinWang commented Mar 19, 2025 •
edited
Loading

Context

Closes SAP/ai-sdk-js-backlog#231.

What this PR does and why it is needed

Add convenience function buildDpiMaskingProvider().

tomfrenken
tomfrenken requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@tomfrenken tomfrenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part, only two parts I would like to be improved

@ZhongpinWang ZhongpinWang requested a review from tomfrenken March 19, 2025 14:20
tomfrenken
tomfrenken requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@tomfrenken tomfrenken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[req] Only missing thing for me now is a little bit more info in the docs, e.g. that there are N (currently N=1) utility functions which are all build functions, or any description of this function, rather than only using it in the examples.

@ZhongpinWang ZhongpinWang requested a review from tomfrenken March 19, 2025 15:08
tomfrenken
tomfrenken approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@tomfrenken tomfrenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomfrenken tomfrenken enabled auto-merge (squash) March 20, 2025 13:30
@tomfrenken tomfrenken merged commit a8d05b0 into main Mar 20, 2025
10 checks passed
@tomfrenken tomfrenken deleted the add-convenience-for-masking branch March 20, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfrenken tomfrenken tomfrenken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhongpinWang @tomfrenken