-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update model list #591
Conversation
.changeset/shy-socks-shake.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
'@sap-ai-sdk/core': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a minor release in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say from the users perspective, the impacted packages are orchestration and foundation-models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to minor.
Regarding the second point, I am still in favour of noting the changes as part of the core
package. As almost all functionality in core
is meant to be used by other packages, it will basically ask us to never put core
in release note. And some changes could affect very widely, such as introducing ErrorWithCause
in very low level in core
. In such case, I prefer not to put all other packages here except core
, even if all other packages has zero code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion, I didn't imply removing core from affected packages in the changeset, rather also including the other 2.
Since we say core is internal and not for users, the changelog might imply that the change is restricted to core. However, the main change is seen in the orchestration/foundation-models by the users. The release notes are mainly for public api changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment for the changelogs, otherwise LGTM.
Context
Closes SAP/ai-sdk-js-backlog#244.
What this PR does and why it is needed
Add
o1
,o3-mini
andalephalpha-pharia-1-7b-control
to the available model list.