chore: Improve error handling by using ErrorWithCause
#581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongpinWang
changed the title
ErrorWithCause
ZhongpinWang
commented
Mar 4, 2025
sample-code/README.md
Outdated
There was a problem hiding this comment.
Some docs were missing.
Also mask grounding input should have been placed as part of the orchestration group.
ZhongpinWang
commented
Mar 4, 2025
| @@ -196,11 +198,12 @@ export async function orchestrationInputFiltering(): Promise<void> { | |||
| }); | |||
| throw new Error('Input was not filtered as expected.'); | |||
| } catch (error: any) { | |||
| if (error.response?.status === 400) { | |||
There was a problem hiding this comment.
I have to make these changes due to the introduction of ErrorWithCause
ZhongpinWang
commented
Mar 4, 2025
| } | ||
| }); | ||
|
|
||
| /* Foundation Models (Azure OpenAI) */ | ||
| app.get('/azure-openai/chat-completion', async (req, res) => { | ||
| try { | ||
| const response = await chatCompletion(); | ||
| res.send(response.getContent()); | ||
| res.header('Content-Type', 'text/plain').send(response.getContent()); |
There was a problem hiding this comment.
This is needed because by default for string response, res.send treats it like html. So line breakers \n won't work. Instead, we should have used <br />.
tomfrenken
reviewed
Mar 5, 2025
deekshas8
reviewed
Mar 5, 2025
tomfrenken
reviewed
Mar 5, 2025
tomfrenken
reviewed
Mar 5, 2025
deekshas8
reviewed
Mar 5, 2025
deekshas8
reviewed
Mar 5, 2025
tomfrenken
reviewed
Mar 5, 2025
tomfrenken
requested changes
Mar 5, 2025
jjtang1985
reviewed
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes SAP/ai-sdk-js-backlog#235.
What this PR does and why it is needed
This PR introduces
ErrorWithCausefor all request execution usingexecuteRequest()from core.The most useful information is contained in
error.stackwhich will be by default printed out if not caught usingtry-catch.I also have to make changes to
sample-codesince accessing response data is now a layer deeper wrapper bycause.Also cleaned up
sample-codea bit.Docs are added for general error handling in case of a failing request.