Skip to content

chore: Support new Data Masking Config #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Oct 15, 2025
Merged

chore: Support new Data Masking Config #592

merged 45 commits into from
Oct 15, 2025

Conversation

n-o-u-r-h-a-n
Copy link
Contributor

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Sep 25, 2025 •
edited
Loading

Context

AI/ai-sdk-java-backlog#321.

Provided convenience functions for the functionality to support DPICustomEntity and option field replacement_strategy.

Feature scope:

  • Implementation of withRegex method in DPiMasking class.
  • Implementation of maskingCustomAnonymization method in OrchestrationService class.
    • Testing the method in OrchestrationTest class.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

CharlesDuboisSAP
CharlesDuboisSAP reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add release notes

n-o-u-r-h-a-n and others added 12 commits September 26, 2025 15:35
CharlesDuboisSAP
CharlesDuboisSAP reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also ask someone else for a review

CharlesDuboisSAP
CharlesDuboisSAP reviewed Oct 7, 2025
View reviewed changes
n-o-u-r-h-a-n and others added 15 commits October 8, 2025 11:43
@n-o-u-r-h-a-n
Improving code quality (reducing indentations) of withRegex() functio…
405c3dd 
…n outside builder.
@n-o-u-r-h-a-n
Merge branch 'main' into Data-Masking-Config
d9e9fc6
@n-o-u-r-h-a-n
Merge branch 'main' into Data-Masking-Config
2ba2e34
@n-o-u-r-h-a-n
Fixing Build
aa5c97d
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/Data-Masking-Config' into Data-M…
62a1961 
…asking-Config
@n-o-u-r-h-a-n
Updating Unit Test
97be7ee
@n-o-u-r-h-a-n
Reverting coverage percentage.
9a92fb7
@n-o-u-r-h-a-n
Merge branch 'main' into Data-Masking-Config
ac1c152
@n-o-u-r-h-a-n
Merge branch 'main' into Data-Masking-Config
2cbd7ca
@n-o-u-r-h-a-n
Updating javadoc of maskingRegex() function.
2c5dc23
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/Data-Masking-Config' into Data-M…
d864e84 
…asking-Config
@n-o-u-r-h-a-n
Updating again the javadoc of maskingRegex() function.
48984a2
@n-o-u-r-h-a-n
Splitting Test and updating minor comments.
bd60969
@n-o-u-r-h-a-n
Merge branch 'main' into Data-Masking-Config
9099e21
@n-o-u-r-h-a-n
Splitting 2 Test and updating minor comments.
94933c4
newtork
newtork previously approved these changes Oct 10, 2025
View reviewed changes
newtork
newtork reviewed Oct 10, 2025
View reviewed changes
@n-o-u-r-h-a-n n-o-u-r-h-a-n merged commit 00de28f into main Oct 15, 2025
7 checks passed
@n-o-u-r-h-a-n n-o-u-r-h-a-n deleted the Data-Masking-Config branch October 15, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newtork newtork newtork left review comments

@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@n-o-u-r-h-a-n @newtork @CharlesDuboisSAP @bot-sdk-js