Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prejoinplayer callbacks #96

Closed
wants to merge 1 commit into from
Closed

Fix Prejoinplayer callbacks #96

wants to merge 1 commit into from

Conversation

gpcf
Copy link
Contributor

@gpcf gpcf commented Jul 28, 2024

This commit sets the execution mode of the prejoinplayer callbacks to OR, which allows players to be rejected by a mod.

@S-S-X S-S-X added the bug Something isn't working label Jul 28, 2024
@S-S-X
Copy link
Owner

S-S-X commented Jul 28, 2024

https://github.com/minetest/minetest/blame/90fccc15ebf86b58656c28ed9853780d92feb69e/src/script/cpp_api/s_player.cpp#L145

Have to check what happened with self tests.
I guess I'll try and merge this into docker release and test with that, should bring other stuff from there too as I've kinda messed up git by just releasing locally built docker images that are currently ahead of git master branch.

@S-S-X S-S-X added the in-latest-docker Included with latest docker images, might not yet be available elsewhere label Jan 11, 2025
@S-S-X
Copy link
Owner

S-S-X commented Jan 13, 2025 •
edited
Loading

Now also cddc500

Edit, also:

@S-S-X S-S-X closed this Jan 14, 2025
@S-S-X
Copy link
Owner

S-S-X commented Jan 14, 2025

Merged ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working in-latest-docker Included with latest docker images, might not yet be available elsewhere
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpcf @S-S-X