Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ItemStack:{get,set}_metadata #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TurkeyMcMac
Copy link
Contributor

I ran into this issue when writing tests for Mesecons. I looked at the code of Minetest to replicate its behavior. Because I'm not actually copying the code, I would think this would be OK license-wise, but I'm not knowledgeable about such things. If incorporating these changes would cause legal issues, this PR should be closed, and you should not look at the changes.

@S-S-X
Copy link
Owner

S-S-X commented May 10, 2022

TLDR: ONLY unimportant speculation about copyright law, licensing, etc. follows.

For licensing / legal it should be fine as long as it is not just copy pasting significant portion of original code (with conflicting license).
What "significant" actually means is not always that clear but basically in this case it would be "threshold of originality"-concept.

In this case mostly about if it would even make any sense to write code in some different way, this code snippet would probably have to be patented in addition to being copyrighted and I'd guess you could not really easily patent that code snippet...

Also I am not a lawyer and for sure you cannot rip 1 page from book every day and glue it into your sketchbook, ultimately producing copy of original work, and claim copyright for it... licensing is complicated 🤷

@TurkeyMcMac
Copy link
Contributor Author

I think this change is basically the only way to implement the behavior matching what Minetest does.

@TurkeyMcMac
Copy link
Contributor Author

The new change makes set_metadata more flexible and also reduces its similarity to Minetest's implementation.

@S-S-X S-S-X added the in-latest-docker Included with latest docker images, might not yet be available elsewhere label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-latest-docker Included with latest docker images, might not yet be available elsewhere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants