ItemStack:get_tool_capabilities / core.get_dig_params #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-S-X
commented
Mar 20, 2022
globals.lua
Outdated
| diggable = true | ||
| -- Calculate tool wear | ||
| local real_uses = math.min(cap.uses * math.pow(3, leveldiff), 65535) | ||
| local wear = 65536 / real_uses |
There was a problem hiding this comment.
Suggested change
| local wear = 65536 / real_uses | |
| local wear = math.floor(65536 / real_uses) |
There was a problem hiding this comment.
can 'real_uses' ever be zero? if for example cap.uses was wrongly configured? maybe that's ok here as that really shouldn't occur, right?
There was a problem hiding this comment.
Yes groupcaps.uses can be zero, should probably check better what should happen but a lot of stuff can be skipped as zero means inifinite uses / no tool wear.
|
This needs tests and almost sure contains bugs, errors and few more bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ItemStack:get_tool_capabilities and core.get_dig_params
Closes #1