fix: Responsive books on /aprende #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Did you check that this does not break the style in other sites where it is used?
SergioRibera
approved these changes
Apr 29, 2024
| @@ -150,9 +104,62 @@ pub fn Books() -> impl IntoView { | |||
| "Estos son algunos otros libros que nos interesa compartir." | |||
| </p> | |||
| </div> | |||
| <div class="flex flex-row flex-wrap w-full gap-y-6 justify-center items-center container mx-auto"> | |||
| <div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 w-full gap-y-6 container mx-auto"> | |||
There was a problem hiding this comment.
No me convence mucho que esto sea grid, solo por un tema que prefiero que este centrado. No estoy seguro si se podria centrar usando grid.
There was a problem hiding this comment.
Hay que obtener una preview de esta PR para ver si no afecta a otras paginas igualmente
SergioRibera
added
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes non-responsive book cards on
/aprende. Also improve code style.Before:
After:
