Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elliptic-curve: bump rand_core to 0.9.0 #1751

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

@newpavlov
Copy link
Member

newpavlov commented Feb 14, 2025

@tarcieri
BTW how important is dependency on ff and group crates for elliptic-curve and its downstream users?

@tarcieri
Copy link
Member

@newpavlov extremely. They provide the traits that generic protocol implementations such as the ecdsa crate are written in terms of

@newpavlov
Copy link
Member

newpavlov commented Feb 14, 2025

I mean, why can't we define those traits in our crates? Judging by the commit history, development is not particularly active for both crates. And it seems a bit strange to unconditionally depend on third-party crates for such important piece of functionality.

@tarcieri
Copy link
Member

I would rather work with @str4d first than try to vendor ff and group into elliptic-curve.

Among other problems there are already existing forks of those crates in e.g. ark-ff and if anything I would like to see those forks resolved so there actually are a common set of traits for the whole Rust elliptic curve ecosystem.

@newpavlov
Copy link
Member

Maybe we should ask zkcrypto developers whether they would be open to transferring those crates under our umbrella?

@baloo baloo force-pushed the baloo/elliptic-curve/bump-rand-core branch 3 times, most recently from a4b9109 to 5b2cfed Compare February 23, 2025 05:23
@baloo baloo force-pushed the baloo/elliptic-curve/bump-rand-core branch from 45a2844 to 7b847ce Compare February 23, 2025 06:01
@baloo baloo force-pushed the baloo/elliptic-curve/bump-rand-core branch from 7b847ce to 5a1c603 Compare February 23, 2025 07:08
@tarcieri tarcieri merged commit fbb4321 into RustCrypto:master Feb 23, 2025
81 checks passed
@str4d
Copy link

str4d commented Feb 23, 2025

I would rather work with @str4d first than try to vendor ff and group into elliptic-curve.

Among other problems there are already existing forks of those crates in e.g. ark-ff and if anything I would like to see those forks resolved so there actually are a common set of traits for the whole Rust elliptic curve ecosystem.

The main thing I need to know here is timing. Just as changes to rand and the RustCrypto traits are very disruptive, so are changes to ff (which is partly why not much happens there). So I need to coordinate with @tarcieri on when these updates need to happen; in particular, some of our stack depends on digest, and I will not cut our stack before I know that digest 0.11.0 is imminently ready.

@tarcieri
Copy link
Member

tarcieri commented Feb 23, 2025

One thing I'd like to see done before we cut final releases of the digest-based crates is a migration to newtypes which would restore readable type names, and uncomplicate things like trait-based OID support. See #1069.

I would expect we would have some releases out in 1-2 months.

Once we do start getting the symmetric crypto traits and their algorithm implementations release, I can do some more work on elliptic-curve and the concrete curve implementations, where I'd like to make quite a few changes. I would expect final releases of those in 3-4 months from now, depending on when we actually get the other crates out.

@baloo baloo deleted the baloo/elliptic-curve/bump-rand-core branch February 23, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants