-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elliptic-curve: bump rand_core to 0.9.0 #1751
elliptic-curve: bump rand_core to 0.9.0 #1751
Conversation
@tarcieri |
@newpavlov extremely. They provide the traits that generic protocol implementations such as the |
I mean, why can't we define those traits in our crates? Judging by the commit history, development is not particularly active for both crates. And it seems a bit strange to unconditionally depend on third-party crates for such important piece of functionality. |
I would rather work with @str4d first than try to vendor Among other problems there are already existing forks of those crates in e.g. |
Maybe we should ask zkcrypto developers whether they would be open to transferring those crates under our umbrella? |
1113fea
to
7eee24b
Compare
a4b9109
to
5b2cfed
Compare
45a2844
to
7b847ce
Compare
7b847ce
to
5a1c603
Compare
The main thing I need to know here is timing. Just as changes to rand and the RustCrypto traits are very disruptive, so are changes to ff (which is partly why not much happens there). So I need to coordinate with @tarcieri on when these updates need to happen; in particular, some of our stack depends on |
One thing I'd like to see done before we cut final releases of the I would expect we would have some releases out in 1-2 months. Once we do start getting the symmetric crypto traits and their algorithm implementations release, I can do some more work on |
This pulls:
rand_core
from0.6.4
to0.9.0
crypto-bigint#762