Skip to content

Set AES-GCM record confidentiality limits #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
42Pupusas wants to merge 2 commits into
base: master
Choose a base branch
from
+48 −6
Open

Set AES-GCM record confidentiality limits #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2818524
Set AES-GCM record confidentiality limits
42Pupusas Oct 16, 2026
456953f
Fix module declaration order in lib.rs
42Pupusas Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ pub const TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256: SupportedCipherSuite =
common: CipherSuiteCommon {
suite: CipherSuite::TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
hash_provider: hash::SHA256,
confidentiality_limit: u64::MAX,
confidentiality_limit: 1 << 24,
},
kx: rustls::crypto::KeyExchangeAlgorithm::ECDHE,
sign: &TLS12_ECDSA_SCHEMES,
Expand All @@ -117,7 +117,7 @@ pub const TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384: SupportedCipherSuite =
common: CipherSuiteCommon {
suite: CipherSuite::TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
hash_provider: hash::SHA384,
confidentiality_limit: u64::MAX,
confidentiality_limit: 1 << 24,
},
kx: rustls::crypto::KeyExchangeAlgorithm::ECDHE,
sign: &TLS12_ECDSA_SCHEMES,
Expand Down Expand Up @@ -152,7 +152,7 @@ pub const TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256: SupportedCipherSuite =
common: CipherSuiteCommon {
suite: CipherSuite::TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
hash_provider: hash::SHA256,
confidentiality_limit: u64::MAX,
confidentiality_limit: 1 << 24,
},
kx: rustls::crypto::KeyExchangeAlgorithm::ECDHE,
sign: &TLS12_RSA_SCHEMES,
Expand All @@ -166,7 +166,7 @@ pub const TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384: SupportedCipherSuite =
common: CipherSuiteCommon {
suite: CipherSuite::TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
hash_provider: hash::SHA384,
confidentiality_limit: u64::MAX,
confidentiality_limit: 1 << 24,
},
kx: rustls::crypto::KeyExchangeAlgorithm::ECDHE,
sign: &TLS12_RSA_SCHEMES,
Expand Down Expand Up @@ -210,7 +210,7 @@ pub const TLS13_AES_128_GCM_SHA256: SupportedCipherSuite =
common: CipherSuiteCommon {
suite: CipherSuite::TLS13_AES_128_GCM_SHA256,
hash_provider: hash::SHA256,
confidentiality_limit: u64::MAX,
confidentiality_limit: 1 << 24,
},
hkdf_provider: &rustls::crypto::tls13::HkdfUsingHmac(hmac::SHA256),
aead_alg: &aead::gcm::Tls13Aes128Gcm,
Expand All @@ -222,7 +222,7 @@ pub const TLS13_AES_256_GCM_SHA384: SupportedCipherSuite =
common: CipherSuiteCommon {
suite: CipherSuite::TLS13_AES_256_GCM_SHA384,
hash_provider: hash::SHA384,
confidentiality_limit: u64::MAX,
confidentiality_limit: 1 << 24,
},
hkdf_provider: &rustls::crypto::tls13::HkdfUsingHmac(hmac::SHA384),
aead_alg: &aead::gcm::Tls13Aes256Gcm,
Expand Down Expand Up @@ -264,6 +264,8 @@ mod aead;
mod hash;
mod hmac;
mod kx;
#[cfg(test)]
mod limit_tests;
mod misc;
pub mod quic;
pub mod sign;
Expand Down
40 changes: 40 additions & 0 deletions src/limit_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
use crate::{
TLS13_AES_128_GCM_SHA256, TLS13_AES_256_GCM_SHA384, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
};
use rustls::{CipherSuite, SupportedCipherSuite};

#[test]
fn aes_gcm_confidentiality_limits_match_the_reference_providers() {
let limits = [
(
&TLS13_AES_128_GCM_SHA256,
CipherSuite::TLS13_AES_128_GCM_SHA256,
1 << 24,
),
(
&TLS13_AES_256_GCM_SHA384,
CipherSuite::TLS13_AES_256_GCM_SHA384,
1 << 24,
),
#[cfg(feature = "tls12")]
(
&TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
CipherSuite::TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
1 << 24,
),
#[cfg(feature = "tls12")]
(
&TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
CipherSuite::TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
1 << 24,
),
];
for (suite, suite_id, expected) in limits {
let actual = match suite {
SupportedCipherSuite::Tls13(inner) => inner.common.confidentiality_limit,
SupportedCipherSuite::Tls12(inner) => inner.common.confidentiality_limit,
};
assert_eq!(actual, expected, "{suite_id:?}");
}
}
Loading