sha2: add soft-compact backend #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
force-pushed
the
sha2/soft-compact
branch
from
37b5217 to
4769ab6
Compare
newpavlov
commented
Apr 29, 2025
tarcieri
approved these changes
Apr 29, 2025
newpavlov
added a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new backend results in a much smaller binary code (e.g. for SHA-256 on
thumbv7em-none-eabiwe get ~150 instructions vs ~1680 instructions, for SHA-512 it's ~330 vs ~7950) while being somewhat slower on non-embedded CPUs (e.g. for SHA-256 on my x86-64 laptop withopt-level=sit results in 289 MB/s vs 315 MB/s).We probably should also backport this PR to the
backports/digest-v0.10branch and release sha2 v0.10.9 with this addition.Closes #561