Skip to content

x509-cert: relax serialnumber parsing, allow rfc-invalid values #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

x509-cert: relax serialnumber parsing, allow rfc-invalid values #982

wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Apr 4, 2023

Fixes #978

@baloo baloo force-pushed the baloo/x509-cert/parse-invalid-serial-number branch from 67db5a2 to 2c8219f Compare April 4, 2023 22:48
@lumag
Copy link
Contributor

lumag commented Apr 4, 2023

Thanks, this fixes the issue for me!

tarcieri
tarcieri requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems this needs more discussion (happening on Zulip)

@tarcieri
Copy link
Member

tarcieri commented Apr 4, 2023

Upon further reflection, I think before tolerating things which don't conform to the RFC5280 profile, we should both know which profile such certs do conform to, and have an easy way to query whether a given cert conforms to the RFC5280 profile.

Possibly we could have an enum with variants like Profile::Rfc5280 and Profile::X509?

@tarcieri
Copy link
Member

tarcieri commented Apr 5, 2023

I opened an issue to discuss: #984

@baloo baloo closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x509-cert/der regression
3 participants
@baloo @lumag @tarcieri