Skip to content

Conversation

dishmaker
Copy link
Contributor

Note: I think it would be better for SliceReader::read_nested to return errors with relative

ErrorKind::Incomplete {
    expected_len: 3,
    actual_len: 2
},

instead of absolute:

ErrorKind::Incomplete {
    expected_len: 5,
    actual_len: 4
},

At first, it was counter-intuitive for me, when I set length to 02 for tag 31 and error returned actual_len: 4.

@dishmaker dishmaker changed the title der: add negative read_nested tests (too short) der: add negative read_nested tests Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant