[WIP] der: remove lifetime from OctetStringRef
#1998
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Custom derive needs to be updated to be aware that certain types are reference types and need to be used as e.g. |
Following the pattern of #1921, removes the lifetime from the struct, instead changing `OctetStringRef` to a proper reference type to be used as `&OctetStringRef`. This makes it possible to `impl Borrow<OctetStringRef> for OctetString` and `impl ToOwned for OctetStringRef`, so they can work with `Cow`.
tarcieri
force-pushed
the
der/remove-octet-string-ref-lifetime
branch
from
8cee1e0 to
2359ca5
Compare
tarcieri
commented
Aug 18, 2025
Comment on lines
+86
to
91
| impl FixedTag for OctetStringRef { | ||
| const TAG: Tag = Tag::OctetString; | ||
| } | ||
|
|
||
| impl OrdIsValueOrd for OctetStringRef<'_> {} | ||
|
|
||
| impl<'a> From<&OctetStringRef<'a>> for OctetStringRef<'a> { | ||
| fn from(value: &OctetStringRef<'a>) -> OctetStringRef<'a> { | ||
| *value | ||
| } | ||
| impl FixedTag for &OctetStringRef { | ||
| const TAG: Tag = Tag::OctetString; | ||
| } |
There was a problem hiding this comment.
This is a little weird, but seems to work
dishmaker
reviewed
Aug 19, 2025
Co-authored-by: dishmaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the pattern of #1921, removes the lifetime from the struct, instead changing
OctetStringRefto a proper reference type to be used as&OctetStringRef.This makes it possible to
impl Borrow<OctetStringRef> for OctetStringandimpl ToOwned for OctetStringRef, so they can work withCow.cc @dishmaker