Skip to content

x509-cert: fixup Arbitrary for certificates #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

baloo
Copy link
Member

@baloo baloo commented Jul 12, 2023

Fixes #1149

This broke with the parsing profiles (#987)

Copy link
Contributor

@stormshield-guillaumed stormshield-guillaumed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarcieri tarcieri merged commit 6964132 into RustCrypto:master Jul 12, 2023
@baloo baloo deleted the baloo/x509-cert/missing-arbitrary branch July 12, 2023 16:41
baloo added a commit to baloo/formats that referenced this pull request Jul 25, 2023
Added
- `add_attribute` to `RequestBuilder` ([RustCrypto#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([RustCrypto#1122])
- use the shortest name when looking attr OID ([RustCrypto#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([RustCrypto#1158])

Fixed
- RDN string representation ([RustCrypto#1126])
- `Arbitrary` for certificates ([RustCrypto#1150])

[RustCrypto#1122]: RustCrypto#1122
[RustCrypto#1126]: RustCrypto#1126
[RustCrypto#1130]: RustCrypto#1130
[RustCrypto#1137]: RustCrypto#1137
[RustCrypto#1150]: RustCrypto#1150
[RustCrypto#1158]: RustCrypto#1158
@baloo baloo mentioned this pull request Jul 25, 2023
baloo added a commit that referenced this pull request Jul 25, 2023
Added
- `add_attribute` to `RequestBuilder` ([#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([#1122])
- use the shortest name when looking attr OID ([#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([#1158])

Fixed
- RDN string representation ([#1126])
- `Arbitrary` for certificates ([#1150])

[#1122]: #1122
[#1126]: #1126
[#1130]: #1130
[#1137]: #1137
[#1150]: #1150
[#1158]: #1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509-cert: Certificate doesn't implement Arbitrary anymore
3 participants