Repository navigation
Fix Montgomery reduction in repeated squaring - #1344
Merged
Merged
Conversation
Closed
tarcieri
force-pushed
the
fixed-monty-form/issue-1343-pow-test
branch
from
September 11, 2026 20:17
9579434 to
04038c9
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 91.06% 91.05% -0.01%
==========================================
Files 189 189
Lines 22645 22621 -24
==========================================
- Hits 20622 20598 -24
Misses 2023 2023 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@andrewwhitehead would you mind opening a separate PR with the fix? Feel free to reuse my test if you'd like |
tarcieri
changed the title
tarcieri
marked this pull request as ready for review
October 6, 2026 17:04
tarcieri
force-pushed
the
fixed-monty-form/issue-1343-pow-test
branch
from
October 6, 2026 17:13
e0b4c96 to
0113271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures each intermediate square is fully reduced using a carry-aware conditional subtraction, preserving the invariant that inputs remain below the modulus.
Additionally adds a regression test.
Closes #1343