alloc: restrict impl ZeroableOption for Box to T: Sized
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the kernel side, if you decide to send it as a fix, then the fix tag would be: |
ojeda
force-pushed
the
zeroable-option-box-fix
branch
from
9314dca to
b41aad0
Compare
y86-dev
reviewed
Apr 1, 2025
Similar to what was done for `Zeroable<NonNull<T>>` in commit 9caa350 ("last docs changes and zeroable unsized pointer fixes"), the latest Rust documentation [1] says it guarantees that `transmute::<_, Option<T>>([0u8; size_of::<T>()])` is sound and produces `Option::<T>::None` only in some cases. In particular, it says: `Box<U>` (specifically, only `Box<U, Global>`) when `U: Sized` Thus restrict the `impl` to `Sized`, and use similar wording as in that commit too. Link: https://doc.rust-lang.org/stable/std/option/index.html#representation [1] Signed-off-by: Miguel Ojeda <[email protected]>
ojeda
force-pushed
the
zeroable-option-box-fix
branch
from
b41aad0 to
a6007cf
Compare
It allows, for instance, kitty to pick it up as links properly [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]>
y86-dev
pushed a commit
to y86-dev/linux
that referenced
this pull request
Apr 2, 2025
It allows, for instance, kitty to pick it up as links properly [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 [ Change case in title. - Benno ] Signed-off-by: Benno Lossin <[email protected]>
y86-dev
pushed a commit
to y86-dev/linux
that referenced
this pull request
Apr 2, 2025
"Normal" comments in Rust (`//`) are also formatted in Markdown, like the documentation (`///` and `//!`), see Documentation/rust/coding-guidelines.rst Thus use Markdown autolinks for a couple links that were missing it. It also helps to get proper linking in some software like kitty [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 [ Change case in title. Reworded commit message. - Benno ] Signed-off-by: Benno Lossin <[email protected]>
y86-dev
pushed a commit
to y86-dev/linux
that referenced
this pull request
Apr 7, 2025
"Normal" comments in Rust (`//`) are also formatted in Markdown, like the documentation (`///` and `//!`), see Documentation/rust/coding-guidelines.rst Thus use Markdown autolinks for a couple links that were missing it. It also helps to get proper linking in some software like kitty [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 Fixes: 84837cf ("rust: pin-init: change examples to the user-space version") [ Change case in title. Reworded commit message. - Benno ] Signed-off-by: Benno Lossin <[email protected]>
y86-dev
pushed a commit
to y86-dev/linux
that referenced
this pull request
Apr 7, 2025
"Normal" comments in Rust (`//`) are also formatted in Markdown, like the documentation (`///` and `//!`), see Documentation/rust/coding-guidelines.rst Thus use Markdown autolinks for a couple links that were missing it. It also helps to get proper linking in some software like kitty [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 Fixes: 84837cf ("rust: pin-init: change examples to the user-space version") Cc: [email protected] [ Change case in title. Reworded commit message. - Benno ] Signed-off-by: Benno Lossin <[email protected]>
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Apr 7, 2025
"Normal" comments in Rust (`//`) are also formatted in Markdown, like the documentation (`///` and `//!`), see Documentation/rust/coding-guidelines.rst Thus use Markdown autolinks for a couple links that were missing it. It also helps to get proper linking in some software like kitty [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 Fixes: 84837cf ("rust: pin-init: change examples to the user-space version") Cc: [email protected] [ Change case in title. Reworded commit message. - Benno ] Signed-off-by: Benno Lossin <[email protected]>
ojeda
added a commit
to ojeda/linux
that referenced
this pull request
Apr 8, 2025
"Normal" comments in Rust (`//`) are also formatted in Markdown, like the documentation (`///` and `//!`), see Documentation/rust/coding-guidelines.rst Thus use Markdown autolinks for a couple links that were missing it. It also helps to get proper linking in some software like kitty [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 Fixes: 84837cf ("rust: pin-init: change examples to the user-space version") Cc: [email protected] [ Change case in title. Reworded commit message. - Benno ] Signed-off-by: Benno Lossin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
ojeda
added a commit
to Rust-for-Linux/linux
that referenced
this pull request
Apr 8, 2025
"Normal" comments in Rust (`//`) are also formatted in Markdown, like the documentation (`///` and `//!`), see Documentation/rust/coding-guidelines.rst Thus use Markdown autolinks for a couple links that were missing it. It also helps to get proper linking in some software like kitty [1]. Suggested-by: Benno Lossin <[email protected]> Link: Rust-for-Linux/pin-init#32 (comment) [1] Signed-off-by: Miguel Ojeda <[email protected]> Link: Rust-for-Linux/pin-init@dd230d6 Fixes: 84837cf ("rust: pin-init: change examples to the user-space version") Cc: [email protected] [ Change case in title. Reworded commit message. - Benno ] Signed-off-by: Benno Lossin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what was done for
Zeroable<NonNull<T>>in commit 9caa350 ("last docs changes and zeroable unsized pointer fixes"), the latest Rust documentation [1] says it guarantees thattransmute::<_, Option<T>>([0u8; size_of::<T>()])is sound and producesOption::<T>::Noneonly in some cases. In particular, it says:Thus restrict the
impltoSized, and use similar wording as in that commit too.Link: https://doc.rust-lang.org/stable/std/option/index.html#representation [1]