feat: added image access qualifier, fixes #28 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schell
force-pushed
the
feature/image-access-qualifier
branch
from
73a6755 to
c9ba1f7
Compare
|
I just have a few tests to fix up. |
schell
requested review from
Firestar99,
LegNeato and
eddyb
and removed request for
eddyb,
fornwall and
LegNeato
LegNeato
reviewed
Oct 12, 2024
| @@ -420,6 +435,20 @@ mod params { | |||
| use super::*; | |||
| use proc_macro2::TokenStream; | |||
|
|
|||
| pub fn image_access_from_str(s: &str) -> Result<AccessQualifier, &'static str> { | |||
There was a problem hiding this comment.
Any reason to not use TryFrom instead?
There was a problem hiding this comment.
Just that this is a smaller diff and it follows the style that's already in the module.
|
I'm on my phone so I may have missed it, but I can't find where a test actually uses it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify the image access qualifier from the
Image!macro, or from theImagetype variables themselves.Fixes #28 .