Skip to content

fix: array stride validation errors #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

redain
Copy link

@redain redain commented Jun 7, 2025

Fix for #266.
Based on this new SPIR-V validation https://github.com/KhronosGroup/SPIRV-Tools/pull/6012/files
Can compile compute shader with work groups again.

@Firestar99
Copy link
Member

I saw you wrote some "normal" tests for your linker step, those would potentially make more sense within compiletests. As the current docs are pretty bad, I wrote entirely new docs for compiletests in PR #275, which will hopefully help in debugging and fixing this issue. Let me know if you have any further questions after reading them or need other kinds of support fixing this issue. :D

@redain
Copy link
Author

redain commented Jul 6, 2025

I am not sure when I will be able to finish this to make all tests pass. There are some corner cases that are still failing, I'm currently just using my branch to compile compute shaders with workgroups for my own use 😅. The most challenging part is that for mixed usage (when same array type is used for both layout-required and layout-prohibited cases) I had to split array type into 2 and then update a lot of type references in SPIR-V and this gets really tricky and error-prone. If anyone wants to take control or fix this themselves - feel free to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants