fix(ci): green full-suite reds and drop low-signal engine tests - #2448
Open
gsxdsm wants to merge 5 commits into
Open
fix(ci): green full-suite reds and drop low-signal engine tests#2448gsxdsm wants to merge 5 commits into
gsxdsm wants to merge 5 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR adds PostgreSQL and engine coverage for merge-request cancellation and transient retry behavior, stabilizes a polling test fixture, refreshes Vitest exclusions, consolidates dashboard test waiting, and removes multiple obsolete engine test suites. ChangesTest coverage and maintenance
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR restructures and trims CI test coverage.
Confidence Score: 3/5The PR should not merge until the PostgreSQL hard-cancel regression is restored to a merge-blocking test lane. The new hard-cancel suite exercises the live PostgreSQL store path, but the current test:pg-gate script still omits it, so a regression can pass the PR gate and be detected only after merge by the non-blocking full suite. Files Needing Attention: packages/core/src/tests/postgres/hard-cancel-merge-request.pg.test.ts and packages/core/package.json
|
| Filename | Overview |
|---|---|
| packages/core/src/tests/postgres/hard-cancel-merge-request.pg.test.ts | Adds real PostgreSQL coverage for user hard-cancel and engine rebound behavior. |
| packages/engine/src/tests/maybe-retry-transient-merge.test.ts | Adds focused fake-timer coverage for transient merge-request requeue and scheduled retry behavior. |
| packages/engine/src/tests/reliability-interactions/starved-refinement-x-triage-poll.test.ts | Gives peer-progress fixtures real prompts so they do not re-enter planning ahead of the starved refinement. |
| packages/engine/vitest.config.ts | Removes exclusions corresponding to deleted expired-quarantine suites. |
| packages/dashboard/app/components/tests/SettingsModal.test-harness.tsx | Combines modal fetch-start and loading-complete readiness checks into one wait loop. |
Reviews (4): Last reviewed commit: "fix(ci): keep PG gate canaries at two fi..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/engine/src/__tests__/maybe-retry-transient-merge.test.ts (1)
12-37: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winVerify that retry scheduling is exercised, not only state mutation.
internalEnqueueMergeis stubbed but never asserted. If this method owns scheduling, a regression could leave the merge requestqueuedwith no retry work enqueued while the test still passes. Assert the callback with the expected task ID, or document that scheduling is owned elsewhere.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/engine/src/__tests__/maybe-retry-transient-merge.test.ts` around lines 12 - 37, Update the transient merge retry test around ProjectEngine.prototype.maybeRetryTransientMerge to assert that the injected internalEnqueueMerge callback is invoked with the expected task ID "FN-5743". Keep the existing queued-state and moveTask assertions, ensuring the test verifies both state transition and retry scheduling.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/core/src/__tests__/postgres/hard-cancel-merge-request.pg.test.ts`:
- Around line 1-12: Move the detailed bug-spec planning from the comments in
packages/core/src/__tests__/postgres/hard-cancel-merge-request.pg.test.ts lines
1-12 and packages/engine/src/__tests__/maybe-retry-transient-merge.test.ts lines
1-6 into their associated PROMPT.md files. Add both Symptom Verification and
Surface Enumeration sections to each PROMPT.md, preserving the relevant test
scenarios; leave only concise FNXC context and executable assertions in the
TypeScript files.
- Around line 45-52: Add an assertion in the “cancels pending merge request on
user in-review→todo hard-cancel” test using the existing store/taskId setup to
verify the persisted task state is “todo” after moveTask completes, while
preserving the existing merge-request and marker assertions.
---
Nitpick comments:
In `@packages/engine/src/__tests__/maybe-retry-transient-merge.test.ts`:
- Around line 12-37: Update the transient merge retry test around
ProjectEngine.prototype.maybeRetryTransientMerge to assert that the injected
internalEnqueueMerge callback is invoked with the expected task ID "FN-5743".
Keep the existing queued-state and moveTask assertions, ensuring the test
verifies both state transition and retry scheduling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: add16b57-0e7a-46ee-bf43-8ebdf08b4614
📒 Files selected for processing (21)
packages/core/src/__tests__/postgres/hard-cancel-merge-request.pg.test.tspackages/dashboard/app/components/__tests__/SettingsModal.test-harness.tsxpackages/engine/src/__tests__/branch-conflicts-ghost-references.test.tspackages/engine/src/__tests__/branch-conflicts-zero-unique.test.tspackages/engine/src/__tests__/maybe-retry-transient-merge.test.tspackages/engine/src/__tests__/merger-ai-dependency-install.slow.test.tspackages/engine/src/__tests__/merger-autostash-orphan-surface.test.tspackages/engine/src/__tests__/merger-empty-cherry-pick-fallback.test.tspackages/engine/src/__tests__/reliability-interactions/branch-group-automerge-precedence.slow.test.tspackages/engine/src/__tests__/reliability-interactions/branch-group-merge-routing.slow.test.tspackages/engine/src/__tests__/reliability-interactions/branch-group-pr-sync.slow.test.tspackages/engine/src/__tests__/reliability-interactions/branch-group-single-pr-e2e.slow.test.tspackages/engine/src/__tests__/reliability-interactions/merge-request-cancel-on-hard-cancel.test.tspackages/engine/src/__tests__/reliability-interactions/merge-runner-spawn-enoent-prevention.test.tspackages/engine/src/__tests__/reliability-interactions/shared-branch-group-lifecycle.slow.test.tspackages/engine/src/__tests__/reliability-interactions/soft-blocker-auto-finalize-interactions.real-git.test.tspackages/engine/src/__tests__/reliability-interactions/starved-refinement-x-triage-poll.test.tspackages/engine/src/__tests__/self-healing-already-merged.real-git.test.tspackages/engine/src/__tests__/workspace-merger-lease.test.tspackages/engine/src/__tests__/worktree-db-hydrate.test.tspackages/engine/vitest.config.ts
💤 Files with no reviewable changes (16)
- packages/engine/src/tests/branch-conflicts-zero-unique.test.ts
- packages/engine/src/tests/reliability-interactions/branch-group-automerge-precedence.slow.test.ts
- packages/engine/src/tests/reliability-interactions/branch-group-pr-sync.slow.test.ts
- packages/engine/src/tests/reliability-interactions/merge-request-cancel-on-hard-cancel.test.ts
- packages/engine/src/tests/reliability-interactions/branch-group-merge-routing.slow.test.ts
- packages/engine/src/tests/self-healing-already-merged.real-git.test.ts
- packages/engine/src/tests/reliability-interactions/soft-blocker-auto-finalize-interactions.real-git.test.ts
- packages/engine/src/tests/reliability-interactions/shared-branch-group-lifecycle.slow.test.ts
- packages/engine/src/tests/reliability-interactions/branch-group-single-pr-e2e.slow.test.ts
- packages/engine/src/tests/merger-ai-dependency-install.slow.test.ts
- packages/engine/src/tests/branch-conflicts-ghost-references.test.ts
- packages/engine/src/tests/worktree-db-hydrate.test.ts
- packages/engine/src/tests/merger-empty-cherry-pick-fallback.test.ts
- packages/engine/src/tests/workspace-merger-lease.test.ts
- packages/engine/src/tests/reliability-interactions/merge-runner-spawn-enoent-prevention.test.ts
- packages/engine/src/tests/merger-autostash-orphan-surface.test.ts
Fix the always-red starved-refinement FIFO poll fixture (peer todos need PROMPT.md), replace the expired SQLite FN-5743 suite with PG moveTask + unit coverage, delete expired quarantine/value-audit dead weight (~34s), and clear exclude/ledger drift.
Peer todo PROMPT.md keeps unplanned peers out of the admission queue so FN-R1 surfaces within seven polls; re-home hard-cancel merge-request checks on the real PG moveTask path and drop expired vitest excludes without ledger entries.
Add hard-cancel-merge-request.pg.test.ts to packages/core test:pg-gate so merge-blocking CI covers the user hard-cancel merge-request path. Assert the persisted task lands in todo, not only MR cancelled / handoff-marker cleared.
gsxdsm
force-pushed
the
feature/speed-up-ci
branch
from
July 26, 2026 14:18
5223756 to
1f57f75
Compare
Remove hard-cancel-merge-request.pg.test.ts from test:pg-gate so the FN-8497 allowlist policy stays green; coverage remains on the non-blocking core PG lane. Assert transient merge retry actually schedules internalEnqueueMerge after the backoff timer.
Collaborator
Author
Review feedback follow-upAddressed the open Greptile P1 (PG gate allowlist) in
All review threads resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starved-refinement-x-triage-pollby giving peer-progress todos realPROMPT.mdfiles so they do not re-enter planning FIFO ahead of the starved refinement.executor-task-done-invariantremains ledger-locked.moveTaskpath plus a focusedmaybeRetryTransientMergeunit test (sync SQLite TaskStore is gone).waitForSettingsModalReadyinto a single assertion body (no timeout/worker appeasement).Test plan
pnpm test:gate(exit 0)pnpm --filter @fusion/engine exec vitest run --project=engine-reliability(102 files / 517 tests pass)pnpm check:quarantine-ledger+check-no-test-timeout-appeasementcleanSummary by CodeRabbit
Bug Fixes
Reliability