Chapter 8 Fixes #162
Open
Chapter 8 Fixes #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ags, and removed all code except for the File class import. This pretag code block and the paragaph preceding it focus exclusively on importing the File class now.
…on appears to work fine without it. I am unable to test the Java code.
…anges to the code in 8.4 so that the code is more in-line with what the text is describing for each one.
…xml ids for all code.
…amples to match some of the Java code examples.
…e that will create a file so the last block of Java code has something to delete. The Python example provided will not run because the os library cannot be imported. I was unable to test the Java code within the book.
…isted in PR). The chapter is in a state that could be usable in a class now, though, I believe there is still work to do. 8.2 and 8.4 take different approaches to presenting the content. I'm not sure which one would work better, but I think it would be a good idea to settle on one or the other at some point and rewrite one of these sections to match the presentation of the other. Additionally, I couldn't get the data files to work in the section on writing to files. Not sure what the problem was here. Finally, I was unable to test Java code in the book. I worry that the two Java code blocks in the section on deleting files will need to be combined into one code block for the deletion to work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chapter has been refined, and issues involving Chapter 8 have been resolved. The chapter is in a usable state now. There are concerns I still have for this chapter, though, these may need to be taken care of at another time. These concerns are detailed in the final commit in for this branch:
issues #157, #158, and #159.