Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted disambiguate_symbol for USD #1120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igor-alexandrov
Copy link

USD should not have disambiguate_symbol and prices in USD should always be formatted like $10,000, the documentation confirms this: https://github.com/RubyMoney/money/blob/main/lib/money/money/formatter.rb#L181.

Currently, Money.new(100, 'USD').format(disambiguate: true) prints US$1.00, which is wrong and confusing.

@s-mage
Copy link

s-mage commented Mar 22, 2025

but this is correct. There are other currencies that use this symbol, e.g. Mexican Peso. If you're in Mexico you'd think $ means peso, not US dollar. If you're outside of Mexico and US, you, strictly speaking, can't tell.

@igor-alexandrov
Copy link
Author

If this is correct, then the documentation should be updated because it says the opposite.

At the same time, if you really need to disambiguate USD, you can always override the default config with Money::Currency.inherit, so I think, the proposed change is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants