Skip to content
forked from iree-org/iree
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iree): set CPU stack allocation limit as an LLVM target option #34

Merged

Conversation

AGindinson
Copy link

@AGindinson AGindinson commented Mar 7, 2025

In order to systemically address exceeded stack allocation limit failures for the CPU pipeline, we first need a way of conveying the limit itself to the whole pipeline. Therefore, create a new context-wide attribute, as well as a bound CLI option to replace the one specific to LLVMCPUCheckIRBeforeLLVMConversionPass.

A further direction for improvement would be unit-testing all the target properties & corresponding CLI options on the basis of this PR.

Copy link
Author

AGindinson commented Mar 7, 2025

@AGindinson AGindinson marked this pull request as ready for review March 10, 2025 07:58
@AGindinson AGindinson marked this pull request as draft March 10, 2025 08:53
@AGindinson AGindinson marked this pull request as ready for review March 10, 2025 08:53
Copy link
Collaborator

@chrsmcgrr chrsmcgrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small test that shows this new target option appear in the IR?

Copy link
Author

AGindinson commented Mar 10, 2025

Can you add a small test that shows this new target option appear in the IR?

Done on a basic level, thanks. Locally, ctest -R iree/compiler/Codegen/LLVMCPU/test/ shows 100%.

@AGindinson AGindinson requested a review from chrsmcgrr March 10, 2025 11:44
Copy link
Collaborator

@chrsmcgrr chrsmcgrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request, looks good.

@AGindinson AGindinson merged commit bb8d9b9 into integrate-iree-20250217 Mar 10, 2025
1 check passed
@AGindinson AGindinson deleted the artem/cpu-stack/stack-limit-option branch March 10, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants