-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iree): set CPU stack allocation limit as an LLVM target option #34
refactor(iree): set CPU stack allocation limit as an LLVM target option #34
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a small test that shows this new target option appear in the IR?
Done on a basic level, thanks. Locally, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small request, looks good.
In order to systemically address
exceeded stack allocation limit
failures for the CPU pipeline, we first need a way of conveying the limit itself to the whole pipeline. Therefore, create a new context-wide attribute, as well as a bound CLI option to replace the one specific toLLVMCPUCheckIRBeforeLLVMConversionPass
.A further direction for improvement would be unit-testing all the target properties & corresponding CLI options on the basis of this PR.