Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bfloat16 support in iree-turbine #4

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix Bfloat16 support in iree-turbine #4

merged 1 commit into from
Mar 19, 2025

Conversation

DavidGinten
Copy link

No description provided.

@DavidGinten Graphite App
Copy link
Author

DavidGinten commented Feb 19, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DavidGinten Graphite App
Copy link
Author

WIth this line added the reproducer doesn't fail anymore and yields the output

@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch 2 times, most recently from 845939e to cb2c6d2 Compare February 20, 2025 15:20
@DavidGinten Graphite App
Copy link
Author

Do we need the Test SHARK Studio CI? It isn't on upstream anymore (outsourced to nodeAI anywhere?). Also, the TK CI is about to run its jobs on AMDGPU which is not available (Waiting for a runner to pick up this job...). Besides that, I think we are quite far behind upstream. Is there any plan to bump eventually?

@DavidGinten Graphite App
Copy link
Author

DavidGinten commented Feb 20, 2025 •
edited
Loading

But other than that, it seems that we just need to adjust this one line in ir_utils.py. (as far as I can see by now). I will also add a test

@DavidGinten DavidGinten marked this pull request as ready for review February 20, 2025 16:23
@chrsmcgrr
Copy link

Yeah we need to update our fork and create an integration branch. I can show you today how to do it. That's why you're seeing differences to upstream.

@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch from cb2c6d2 to bca2c88 Compare February 21, 2025 10:31
@DavidGinten DavidGinten changed the base branch from main to integrate-iree-turbine-20250221 February 21, 2025 11:58
@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch 5 times, most recently from 6179551 to ee590c4 Compare February 26, 2025 12:57
@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch 14 times, most recently from 65f0e97 to 1afa03a Compare March 5, 2025 12:23
@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch 10 times, most recently from af19ee4 to c3a8c30 Compare March 6, 2025 11:41
@chrsmcgrr Graphite App
Copy link

chrsmcgrr commented Mar 10, 2025 •
edited
Loading

Can we close this now?

edit: nevermind we need this sorry for the noise.

chrsmcgrr
chrsmcgrr requested changes Mar 10, 2025
View reviewed changes
@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch from c3a8c30 to 9e00247 Compare March 10, 2025 08:43
@DavidGinten DavidGinten requested a review from chrsmcgrr March 10, 2025 08:52
@DavidGinten DavidGinten force-pushed the ginten/roo-121-attic-torch-fix-bfloat16-support-in-iree-turbine branch from 9e00247 to 0479dec Compare March 17, 2025 10:32
chrsmcgrr
chrsmcgrr approved these changes Mar 18, 2025
View reviewed changes
Copy link

@chrsmcgrr chrsmcgrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to coordinate the merge with the other PR.

@DavidGinten DavidGinten merged commit b952b2a into integrate-iree-turbine-20250221 Mar 19, 2025
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrsmcgrr chrsmcgrr chrsmcgrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidGinten @chrsmcgrr