-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: add maximum tasks in home screen setting #9234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roomote
wants to merge
7
commits into
main
Choose a base branch
from
feature/max-tasks-home-screen-setting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new UISettings option to configure maximum number of tasks shown in home screen (0-20, default 4) - Update HistoryPreview component to respect the new setting - When set to 0, HistoryPreview component does not render at all - Add translation keys for the new setting - Update tests to account for new behavior
Contributor
Author
Review completed. All previously flagged issues have been resolved.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR - Needs Preliminary Review
size:L
This PR changes 100-499 lines, ignoring generated files.
UI/UX
UI/UX related or focused
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new UI setting to configure the maximum number of tasks shown in the home screen history preview, since we removed the ability to hide them from the home page, intentionally.
Changes
Testing
Important
Introduces a new UI setting to control the maximum number of tasks displayed on the home screen, affecting the
HistoryPreviewcomponent and including updates to translations and tests.HistoryPreviewcomponent updated to respect new setting; does not render if set to 0.maxTasksHomeScreen.test.tsandHistoryPreview.spec.tsx.This description was created by
for 59fb67e. You can customize this summary. It will automatically update as commits are pushed.