Fix checkpoints not appearing in chat when metadata is invalid #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
- Modified CheckpointSaved component to show fallback display when checkpoint metadata is missing or invalid - Added console warnings to help debug checkpoint metadata issues - Prevents checkpoints from being completely hidden due to schema validation failures - Fixes issue #5899 where users reported not seeing checkpoints despite having them enabled The component now: - Shows a fallback checkpoint display with default metadata when validation fails - Logs warnings to console for debugging purposes - Displays "metadata unavailable" indicator when using fallback data - Ensures CheckpointMenu still functions with fallback metadata
dosubot
bot
added
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| </span> | ||
| {isCurrent && <span className="text-muted text-sm">{t("chat:checkpoint.current")}</span>} | ||
| {!metadata && ( | ||
| <span className="text-muted text-xs italic"> | ||
| {t("chat:checkpoint.metadataUnavailable", "metadata unavailable")} |
There was a problem hiding this comment.
Avoid providing an inline English fallback string in the translation call. Remove the second argument from t('chat:checkpoint.metadataUnavailable') and manage defaults via the translation JSON files.
Suggested change
| {t("chat:checkpoint.metadataUnavailable", "metadata unavailable")} | |
| {t("chat:checkpoint.metadataUnavailable")} |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
hannesrudolph
added
the
Issue/PR - Triage
|
@roomote-agent use the switch_mode tool to switch to pr-fixer mode and address the comment left by ellipsis-bot on this PR, do not create a new PR |
|
👋 I've received your request and switched to pr-fixer mode. I can see the ellipsis-bot comment about removing the inline English fallback string from the translation call. I'll address this issue now. |
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5899
Problem
Users reported that checkpoints are not appearing in the chat despite having checkpoints enabled in settings. Investigation revealed that the
CheckpointSavedcomponent was returningnullwhen checkpoint metadata failed schema validation, causing checkpoints to be completely hidden from the UI.Root Cause
The
CheckpointSavedcomponent was too strict in its validation - if the checkpoint metadata did not exactly match the expected schema, the entire checkpoint display would be hidden by returningnull.Solution
Modified the
CheckpointSavedcomponent to:nullfor invalid metadata, show a fallback displayChanges
webview-ui/src/components/chat/checkpoints/CheckpointSaved.tsx:nullTesting
The fix ensures that:
This change prioritizes user experience by ensuring checkpoints are always visible, while providing debugging tools for developers to identify and fix underlying metadata issues.
Important
Fix
CheckpointSavedto always display checkpoints with fallback data and log warnings for invalid metadata.CheckpointSavedcomponent now always displays checkpoints, even with invalid metadata, using fallback data.CheckpointSaved.tsxto use fallback metadata when validation fails.CheckpointSaved.tsx.This description was created by
for 1342a1e. You can customize this summary. It will automatically update as commits are pushed.