Modify 500 code error response page #164
Open
+55
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DenTray
requested changes
Apr 9, 2025
There was a problem hiding this comment.
let's rename file to error.blade.php, need to unlink logic from the swagger usage only
| @@ -30,7 +30,7 @@ public function saveData(): void | |||
| public function getDocumentation(): array | |||
| { | |||
| if (!file_exists($this->prodFilePath)) { | |||
| throw new FileNotFoundException(); | |||
| throw new FileNotFoundException("Documentation file not found :{$this->prodFilePath}"); | |||
There was a problem hiding this comment.
let's move error message to the exception and just pass the path as arg
Suggested change
| throw new FileNotFoundException("Documentation file not found :{$this->prodFilePath}"); | |
| throw new FileNotFoundException($this->prodFilePath); |
| @@ -138,7 +138,21 @@ protected function generateEmptyData(): array | |||
| throw new EmptyContactEmailException(); | |||
| } | |||
|
|
|||
| $data = [ | |||
| $data = $this->generateBaseDataObject(); | |||
There was a problem hiding this comment.
not sure we need to make this change, could you please revert it?
| $documentation = $this->driver->getDocumentation(); | ||
|
|
||
| $this->openAPIValidator->validate($documentation); | ||
| } catch (\Exception $exception) { |
There was a problem hiding this comment.
Suggested change
| } catch (\Exception $exception) { | |
| } catch (Exception $exception) { |
|
|
||
| $this->openAPIValidator->validate($documentation); | ||
| $this->config['info'] = Arr::set($this->config, 'info.description', Arr::get($this->config, 'defaults.error')); |
There was a problem hiding this comment.
let's pass the description view as arg, it would be better to redefine the config field
| app(SwaggerService::class)->getDocFileContent(); | ||
| $description = Arr::get($content, 'info.description'); | ||
|
|
||
| $this->assertEquals($exceptionMessage, Str::replace(''', "'", $description)); |
There was a problem hiding this comment.
it would be better to assert rendered error view instead of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #163