[Mythic Basionland] Bugfix: Uncouple Weapons & Companion Fieldsets

[JacksontChang]

Submission Checklist

Warning

Submission Checklist
Failure to complete this checklist in its entirety will result in your Pull Request being dismissed. If you have any questions, please feel free to create an issue.

Note

Draft Pull Requests
If you are unclear about any of the rules regarding the creation of character sheets, or need assistance from the Roll20 team, please feel free to create a Draft PR and request feedback. We'd much rather provide assistance than reject a PR.

Pull Request Title

Please format your pull request in the following way: [Sheet Name] Change Type: Description. For example: [D&D5e] New Feature: Adding dragons to dungeons.

• The pull request title clearly contains the name of the sheet I am editing.
• The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).

Pull Request Content

• The pull request makes changes to files in only one sub-folder.
• The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)
• The pull request does not, without express prior permission from affected parties, include any material that could be considered to infringe on a Publisher's intellectual property rights, such as logos, images, rules text or other rules content.

New Sheet Details

Please complete this section if you are adding a new sheet to the repository.

If you are submitting a new sheet to the repository, please fill in any empty spaces indicated by [ ].

• The name of this game is: [ ]

  (e.g. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

• The publisher of this game is: [ ]

  (e.g. Wizards of the Coast, Evil Hat)

• The name of this game system/family is: [ ]

  (e.g. Dungeons & Dragons, FATE)

• The rules for this game can be found at the following location: [ ]

  (e.g. a link to purchase, ISBN, Half-Price Books)

• I have followed the Character Sheets Standards when building this sheet.

• I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.

Select EXACTLY One:

• This game is a traditionally published game.
• This game is not a traditionally published game.
• This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system. [ ADD DETAILS HERE ]

Changes / Description

Uncoupling the weapon & companion fieldsets, this was causing an issue where create/deleting one would create/delete the other.

Little concerned about this one since it will blow away any companions on existing sheets. I'm not sure if there's a way to push a migration as part of a change, also not sure how roll20 works with character sheet updates; if you automatically update, or if you only get the latest on creating a new campaign.

We could have an sheet:opened event that checks if any weapon fieldsets have companion data but that's a bit of clutter, and will mostly not do anything. Not looked into the specifics of how to write that one.

[roll20deploy]

Character Sheet Info Roll20 Internal Use only.

[JacksontChang]

Hey @timdenee just pinging you in case you wanted to check the PR.
Especially if you had any feedback on how to handle the data update.

[timdenee]

Thanks for the heads up - good question, not really sure. I'm pretty sure they do automatically update. I would say we might as well just bite the bullet and fix it, not the end of the world to repopulate companions.

[davidroll20]

Hi @JacksontChang and @timdenee! I can confirm that changing the name of the repeating section will result in data loss for those entries. It's typically our policy not to merge PRs that would cause user data to be deleted. My recommendation is to go with your proposed solution of running some code on sheet:open to convert the existing data to the new field. Until there's some code to handle that data, we can't merge this.

Thank you for your efforts and your patience!

[NBrooks-Roll20]

Hi @JacksontChang! We haven't heard from you in a while and will have to close this PR soon. You'll always be welcome to open a new PR with these changes whenever you're ready. Please let us know!

[kfroll20]

@JacksontChang, we are going to go ahead and close this. As stated above, you are more than welcome to open a new PR with the requested handling for the data.