Merged
Conversation
wesrich
force-pushed
the
github-actions
branch
from
f5b4713 to
ca49ddc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI infrastructure by migrating from Travis CI to GitHub Actions and adds support for testing against multiple ActiveSupport versions. Key changes include:
- Removed Travis CI configuration and added GitHub Actions workflow with lint and test jobs
- Created gemfiles for testing against ActiveSupport 7.1, 7.2, 8.0, and 8.1
- Updated test configuration to output JUnit XML reports and changed a skipped test from
xittoitwithskipmetadata
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
New GitHub Actions CI workflow with RuboCop linting and matrix testing across Ruby and ActiveSupport versions |
.travis.yml |
Removed Travis CI configuration |
.ruby-version |
Set Ruby version to 3.4.7 |
.rspec |
Added RSpec JUnit formatter output |
.gitignore |
Added pattern to ignore built gem files |
Gemfile |
Added rubocop and rspec_junit_formatter gems for development/testing |
gemfiles/activesupport-* |
Created gemfiles for testing against multiple ActiveSupport versions |
spec/marsh_grass_spec.rb |
Changed slow test from xit to use skip metadata instead |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wesrich
force-pushed
the
github-actions
branch
2 times, most recently
from
5f532f5 to
d4a43d0
Compare
Braden-077
approved these changes
Nov 5, 2025
wesrich
force-pushed
the
github-actions
branch
from
d4a43d0 to
17fc82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure CI runs on GH Actions with the matrix of supported Ruby/ActiveSupport versions. We may end up wanting to add RSpec in there somewhere, but for now....