More small fixes

Rohde-Schwarz · Jan 10, 2024 · 5a67cec · 5a67cec
1 parent 4b0d025
commit 5a67cec
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/lib/pubkey/classic_mceliece/cmce_encaps.h b/src/lib/pubkey/classic_mceliece/cmce_encaps.h
@@ -54,7 +54,7 @@ class BOTAN_TEST_API Classic_McEliece_Encryptor final : public PK_Ops::KEM_Encry
                        const Classic_McEliece_Matrix& mat);
 
       /**
-      * Fixed-weight-vector generation algorithm according to ISO McEliece.
+      * @brief Fixed-weight-vector generation algorithm according to ISO McEliece.
       */
       std::optional<secure_bitvector> fixed_weight_vector_gen(const Classic_McEliece_Parameters& params,
                                                               const secure_vector<uint8_t>& rand);

diff --git a/src/lib/pubkey/classic_mceliece/cmce_poly.h b/src/lib/pubkey/classic_mceliece/cmce_poly.h
@@ -74,6 +74,9 @@ class BOTAN_TEST_API Classic_McEliece_Polynomial {
  */
 class BOTAN_TEST_API Classic_McEliece_Minimal_Polynomial : public Classic_McEliece_Polynomial {
    public:
+      Classic_McEliece_Minimal_Polynomial(std::vector<Classic_McEliece_GF> coef) :
+            Classic_McEliece_Polynomial(std::move(coef)) {}
+
       /**
        * @brief Serialize the polynomial to bytes according to ISO Section 9.2.9.
        */

diff --git a/src/tests/test_utils_bitvector.cpp b/src/tests/test_utils_bitvector.cpp
@@ -788,7 +788,7 @@ Test::Result test_bitvector_conditional_xor_workload() {
    }
    res.set_ns_consumed(Test::timestamp() - start);
 
-   res.confirm("Prevent compiler from optimizing away", bitvec_vec.at(0).any());
+   res.confirm("Prevent compiler from optimizing away", bitvec_vec.at(0).any() || bitvec_vec.at(0).none());
    return res;
 }