BUG: Fix incorrect Jacobian in only_radial_burn branch of SolidMotor.evaluate_geometry#944
Merged
MateusStano merged 3 commits intorel/v1.12.0from Mar 20, 2026
Merged
Conversation
Merged
…ometry Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Addressing feedback from PR #935 for release v1.12.0
BUG: Fix incorrect Jacobian in Mar 20, 2026
only_radial_burn branch of SolidMotor.evaluate_geometry
| # ∂ṙ/∂h = vdiff/(2π*r*h²) = factor * r | ||
| inner_radius_derivative_wrt_inner_radius = factor * grain_height | ||
| inner_radius_derivative_wrt_height = factor * grain_inner_radius | ||
| # dh/dt = 0, so all partial derivatives of height are zero |
Member
There was a problem hiding this comment.
Suggested change
| # dh/dt = 0, so all partial derivatives of height are zero | |
| # dh/dt = 0 (Height is a constant), so all partial derivatives of height are zero |
Gui-FernandesBR
approved these changes
Mar 20, 2026
Copilot stopped work on behalf of
MateusStano due to an error
March 20, 2026 01:54
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/v1.12.0 #944 +/- ##
============================================
Coverage 81.09% 81.09%
============================================
Files 107 107
Lines 13906 13906
============================================
Hits 11277 11277
Misses 2629 2629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MateusStano
added a commit
that referenced
this pull request
Mar 20, 2026
…or.evaluate_geometry` (#944) * Initial plan * BUG: Fix incorrect Jacobian in only_radial_burn branch of evaluate_geometry Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
geometry_jacobianfunction inSolidMotor.evaluate_geometryhad copy-paste errors in theonly_radial_burnbranch — the formulas were carried over from the non-radial burn case without adjustment, producing a mathematically wrong Jacobian that can degrade or derail LSODA integration.Pull request type
Checklist
CHANGELOG.mdhas been updated (if relevant)Current behavior
For
only_radial_burn,burn_area = 2π·r·h, soṙ = −vdiff / (2π·r·h).The Jacobian was incorrectly computed as:
∂ṙ/∂r = factor * (h − 2r)— copied from the non-radial case whered(burn_area)/dr = 2π(h−2r)∂ṙ/∂h = 0— wrong; height appears in the denominator so it has a non-zero partialNew behavior
Correct partial derivatives for
burn_area = 2π·r·h:Breaking change
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.