ENH: Add explicit timeouts to ThrustCurve API requests and update changelog#940
Open
Copilot wants to merge 3 commits intorel/v1.12.0from
Open
ENH: Add explicit timeouts to ThrustCurve API requests and update changelog#940Copilot wants to merge 3 commits intorel/v1.12.0from
Copilot wants to merge 3 commits intorel/v1.12.0from
Conversation
Open
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from PR #935 for rel/v1.12.0 changes
ENH: Add explicit timeouts to ThrustCurve API requests
Mar 18, 2026
Member
|
@copilot add pr to changelog |
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Author
Copilot
AI
changed the title
ENH: Add explicit timeouts to ThrustCurve API requests
ENH: Add explicit timeouts to ThrustCurve API requests and update changelog
Mar 18, 2026
Gui-FernandesBR
approved these changes
Mar 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/v1.12.0 #940 +/- ##
============================================
Coverage 81.05% 81.06%
============================================
Files 107 107
Lines 13891 13892 +1
============================================
+ Hits 11260 11261 +1
Misses 2631 2631 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Both the search and download
requests.get()calls inMotor._call_thrustcurve_api()had no explicit timeout, allowing indefinite hangs in slow/offline network environments.New behavior
Both ThrustCurve API calls now use an explicit timeout tuple:
Applied to:
/search.json)/download.json)The method docstring now documents
requests.exceptions.Timeoutas a possible exception.Additionally, based on review feedback,
CHANGELOG.mdwas updated under [Unreleased] → Fixed to include this PR change.Breaking change
Additional information
Targeted validation was run for the affected area:
python -m pytest tests/unit/motors/test_genericmotor.py -q→9 passed💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.