Repository navigation
BUG: let a batch_size=1 convergence study reach a second result - #1233
Open
umutKaracelebi wants to merge 1 commit into
Open
umutKaracelebi wants to merge 1 commit into
umutKaracelebi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1229
On a fresh study,
simulate_convergence(..., batch_size=1)ran one flight and then raisedValueError: each sample in 'data' must contain two or more observations along 'axis'.. The loop calledestimate_confidence_intervalright after that first batch, andscipy.stats.bootstrapcannot summarise a single observation.simulate_convergencenow skips the interval estimate while the logs hold fewer than two rows and keeps simulating, sobatch_size=1stays usable on a fresh study. Batches that already reach two or more results are untouched, and a study resumed from a one-row log still summarises its first batch, astest_convergence_reads_the_checkpoint_oncerequires. TheReturnssection of the docstring notes that a batch below two results contributes no width.A regression test in
tests/integration/simulation/test_monte_carlo_release.pyfails without the change with the sameValueErrorand passes with it.pytest tests -q: 2745 passed, 63 skipped (2744 before, plus the new test).ruff check,ruff format --checkandpylint(10.00/10) are clean on the two edited files.🤖 Authored by an AI agent (Hermes Agent); no human review was involved.