Repository navigation
DOC: add notes on the inputs of the drag coefficient models - #1232
Open
MateusStano wants to merge 1 commit into
Open
MateusStano wants to merge 1 commit into
MateusStano wants to merge 1 commit into
Conversation
- alpha and beta are separate signed angles, to be combined for the total angle of attack. The example now uses both. - The Reynolds number uses the rocket diameter as reference length. - A drag CSV with a missing combination loads, but interpolates differently. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1209 and #1142. This is the #1142 item of the v1.14.0 checklist.
Pull request type
Checklist
CHANGELOG.md: not updated here, DOC: backfill the v1.14.0 changelog and add breaking changes #1228 is collecting the entriesCurrent behavior
The drag section that #1142 added to
rocket_usage.rstis correct, but leaves out three things a user needs to build a drag model:alphaandbetaare separate signed angles, and neither is the total angle of attack. The example only usedalpha.New behavior
Two notes in the section cover the three points, and the example now uses
alpha**2 + beta**2.Each point was checked in the code:
Flight.__compute_drag_7d_inputstakesalphafrom the body y and axial velocity components andbetafrom the x and axial ones, and computes the Reynolds number with2 * rocket.radius.Breaking change
🤖 Generated with Claude Code