Repository navigation
MNT: make the parachute noise seed private - #1227
Open
Gui-FernandesBR wants to merge 1 commit into
Open
Gui-FernandesBR wants to merge 1 commit into
Gui-FernandesBR wants to merge 1 commit into
Conversation
Parachute no longer takes a public seed. StochasticParachute and from_dict set it through _set_noise_seed, which also redraws the first noise sample so the sequence is unchanged. to_dict still writes the seed, and from_dict still loads dicts without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XDW575d9C9zpS7Z1v2KXVq
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1227 +/- ##
===========================================
+ Coverage 86.55% 86.56% +0.01%
===========================================
Files 131 131
Lines 18248 18262 +14
===========================================
+ Hits 15794 15808 +14
Misses 2454 2454 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 of 11 tasks
MateusStano
reviewed
Nov 20, 2026
MateusStano
left a comment
Member
There was a problem hiding this comment.
Looks good, one problem before merging.
The noise seed recorded in each Monte Carlo input row (parachutes[i]["seed"]) is a 128-bit integer, and pandas.read_json fails on it with "Value is too big!". It is the same issue as the study seed in #1213, which only got the 63-bit fix at the top level.
It is already like this on develop, but since this PR touches that seed, can you cut it to 63 bits here? A test that reads a real input row with pandas would cover both seeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1209
Parachuteno longer takes a publicseedargument, which was added after v1.13.0 and never released, so there is no deprecation.StochasticParachuteandParachute.from_dictnow set the pressure-noise seed through a private_set_noise_seedmethod, which also redraws the first noise sample so a seeded parachute produces the same sequence as before.to_dictstill writes the seed, andfrom_dictstill loads dicts without one, such as files written by v1.13.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01XDW575d9C9zpS7Z1v2KXVq