Skip to content

MNT: make the parachute noise seed private - #1227

Open
Gui-FernandesBR wants to merge 1 commit into
developfrom
mnt/private-parachute-seed
Open

Gui-FernandesBR wants to merge 1 commit into
developfrom
mnt/private-parachute-seed

Conversation

@Gui-FernandesBR

Copy link
Copy Markdown
Member

Related to #1209

Parachute no longer takes a public seed argument, which was added after v1.13.0 and never released, so there is no deprecation. StochasticParachute and Parachute.from_dict now set the pressure-noise seed through a private _set_noise_seed method, which also redraws the first noise sample so a seeded parachute produces the same sequence as before. to_dict still writes the seed, and from_dict still loads dicts without one, such as files written by v1.13.0.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XDW575d9C9zpS7Z1v2KXVq

Parachute no longer takes a public seed. StochasticParachute and from_dict set it through _set_noise_seed, which also redraws the first noise sample so the sequence is unchanged. to_dict still writes the seed, and from_dict still loads dicts without one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XDW575d9C9zpS7Z1v2KXVq
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.56%. Comparing base (9bf63a0) to head (72830d2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1227      +/-   ##
===========================================
+ Coverage    86.55%   86.56%   +0.01%     
===========================================
  Files          131      131              
  Lines        18248    18262      +14     
===========================================
+ Hits         15794    15808      +14     
  Misses        2454     2454              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gui-FernandesBR Gui-FernandesBR mentioned this pull request Nov 20, 2026
4 of 11 tasks

@MateusStano MateusStano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one problem before merging.

The noise seed recorded in each Monte Carlo input row (parachutes[i]["seed"]) is a 128-bit integer, and pandas.read_json fails on it with "Value is too big!". It is the same issue as the study seed in #1213, which only got the 63-bit fix at the top level.

It is already like this on develop, but since this PR touches that seed, can you cut it to 63 bits here? A test that reads a real input row with pandas would cover both seeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants